Repository navigation
Default bottom of Stepfilled histograms should be set according to ymin #4621
Description
Compare bar:
import numpy
import matplotlib.pyplot as plt
fig, ax = plt.subplots(1,1)
hist1 = ax.hist(1, bins=1, normed=False, log=True, histtype='bar', label='No bottom', alpha=1, facecolor='red')
offset = 1e-9
ax.set_ylim(1e-4, 1.1)
ax.legend()
plt.show()
to stepfilled:
import numpy
import matplotlib.pyplot as plt
fig, ax = plt.subplots(1,1)
hist1 = ax.hist(1, bins=1, normed=False, log=True, histtype='stepfilled', label='No bottom', alpha=1, facecolor='red')
offset = 1e-9
ax.set_ylim(1e-4, 1.1)
ax.legend()
plt.show()
Setting bottom is not really a correct solution since it shifts the top of the bar with the same amount
Activity
petehuang commented on Jan 10, 2017
@jenshnielsen can you update the second code snippet? I think it's the same as the first. Thanks :)
jenshnielsen commented on Jan 10, 2017
I don't remember this but I think it should be correct now
tacaswell commented on Jan 10, 2017
Tagged as medium difficulty because hist.
Dhrumil0 commented on Feb 14, 2018
I was interested in working on this. Can you please verify some things. Currently, the bottom is set to be 1/logbase by default for a stepfilled graph set to a log scale. If the bottom parameter is provided, it's value is used instead. This seems to be the intended behaviour from the comments in the code. Is it supposed to be set to the lower ylim value instead when bottom isn't given?
anntzer commented on Feb 14, 2018
Probably the correct fix is some variant of #9477.
Dhrumil0 commented on Feb 14, 2018
I think this issue is somewhat different. Can you please clarify how the step filled histogram is supposed to behave when bottom isn't set. The code is setting the default to 1/ logbase which seems to be reasonable.