Repository navigation
Make logscale bar/hist autolimits more consistents. - #14581
Merged
dstansby merged 1 commit intoAug 12, 2019
Merged
dstansby merged 1 commit into
dstansby merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
barlog
branch
2 times, most recently
from
85e814f to
7f80dab
Compare
June 24, 2019 10:08
The bottom limit of log-scaled bar/hist plots now defaults to applying normal margins (possibly with null limits expansion) to the data limits, rather than being hardcoded to 1/log_base. See changelog. Delete two tests that asserted that the lower limit was at 1/log_base.
timhoffm
approved these changes
Aug 10, 2019
dstansby
approved these changes
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog.
e.g.
from matplotlib import pyplot as plt fig, axs = plt.subplots(3, 3) axs[0, 0].set_yscale("log") axs[0, 0].bar(0, 1) axs[0, 0].set_title("log-then-bar") axs[0, 1].bar(0, 1) axs[0, 1].set_yscale("log") axs[0, 1].set_title("bar-then-log") axs[0, 2].bar(0, 1, log=True) axs[0, 2].set_title("bar(log=True)") axs[1, 0].set_yscale("log") axs[1, 0].hist(1, 1, histtype="step") axs[1, 0].set_title("log-then-hist(step)") axs[1, 1].hist(1, 1, histtype="step") axs[1, 1].set_yscale("log") axs[1, 1].set_title("hist(step)-then-log") axs[1, 2].hist(1, 1, histtype="step", log=True) axs[1, 2].set_title("hist(step, log=True)") axs[2, 0].set_yscale("log") axs[2, 0].hist(1, 1, histtype="stepfilled") axs[2, 0].set_title("log-then-hist(stepfilled)") axs[2, 1].hist(1, 1, histtype="stepfilled") axs[2, 1].set_yscale("log") axs[2, 1].set_title("hist(stepfilled)-then-log") axs[2, 2].hist(1, 1, histtype="stepfilled", log=True) axs[2, 2].set_title("hist(stepfilled, log=True)") plt.show()This previously gave
This PR makes the all rows always use the "top right/bottom left" behavior. Because hist(histtype="bar") (the default) simply calls bar(), this PR also makes the behavior of hist() more consistent.
The deleted tests are https://github.com/matplotlib/matplotlib/blob/v3.1.0/lib/matplotlib/tests/baseline_images/test_axes/hist_steplog.png, which is now
(the lower margin is much more reasonable IMO) and #4608 (now both histograms go to 1e-2 -- one because that's what's passed as bottom, the other one because it goes basically to minus infinity but relies on the other's sticky margin).
Closes #4621 (which is essentially the same as the issue demo'ed above).
Closes #14981.
PR Summary
PR Checklist