FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Alternate implementation of lazy ticks. by anntzer · Pull Request #10302 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Alternate implementation of lazy ticks. - #10302

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:lazyticks
Jan 24, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Alternate implementation of lazy ticks.#10302
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:lazyticks

Conversation

anntzer commented Jan 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s for me).

I think this is closer than #9727 to being backcompatible, and also simpler if you understand how descriptors work. attn @timhoffm, obviously the credits of the idea go to him.

Milestoned to 2.2 to match #9727.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added this to the v2.2 milestone Jan 23, 2018
jklymak reviewed Jan 23, 2018
View reviewed changes
Comment thread lib/matplotlib/axis.py
anntzer force-pushed the lazyticks branch 2 times, most recently from e2c7538 to ce2ddee Compare January 24, 2018 01:31
timhoffm mentioned this pull request Jan 24, 2018
Closed
1 task done
jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 24, 2018

jklymak commented Jan 24, 2018

Copy link
Copy Markdown
Member

I'm not going to merge in case @efiring or @tacaswell want to have a look....

jklymak commented Jan 24, 2018

Copy link
Copy Markdown
Member

ooops, now there is a conflict. Probably w/ the other tick change?

Alternate implementation of lazy ticks.
c935965 
Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s).

anntzer commented Jan 24, 2018

Copy link
Copy Markdown
Contributor Author

rebased

timhoffm merged commit f3760b2 into matplotlib:master Jan 24, 2018
anntzer deleted the lazyticks branch January 24, 2018 21:59

anntzer commented Jan 24, 2018

Copy link
Copy Markdown
Contributor Author

@timhoffm congrats on getting your commit bit, btw

jklymak commented Jan 24, 2018

Copy link
Copy Markdown
Member

@timhoffm Yes, welcome!

Though I think out of an abundance of caution we make sure (most of) the tests pass before committing 😉 Maybe OK in this case, as the pre-rebase passed, but...

timhoffm commented Jan 24, 2018

Copy link
Copy Markdown
Member

Thanks. @jklymak also thanks for the advice. I will wait next time.

QuLogic mentioned this pull request Feb 5, 2018
Closed
QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL