FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Small fix to constrainedlayout7 test (removed image) by jklymak · Pull Request #10387 · matplotlib/matplotlib · GitHub

Repository navigation

TST: Small fix to constrainedlayout7 test (removed image) - #10387

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
jklymak:tst-constrained-layout7-warning
Feb 6, 2018
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
jklymak:tst-constrained-layout7-warning

Conversation

jklymak commented Feb 6, 2018

Copy link
Copy Markdown
Member

PR Summary

@QuLogic noted that the tests were emitting errors due to #9082. Was written before I understood pytest as well as I do now (which is almost zero, but was really zero before). Now I catch the warning rather than letting it emit and make the warning the test. This drops an image.

jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing labels Feb 6, 2018
jklymak added this to the v2.2 milestone Feb 6, 2018

jklymak commented Feb 6, 2018

Copy link
Copy Markdown
Member Author

xref #10385

dstansby merged commit bf2127b into matplotlib:master Feb 6, 2018
QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL