FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FIX: No rcparam minor ticks in colorbar #8358 by Dih5 · Pull Request #10530 · matplotlib/matplotlib · GitHub

Repository navigation

FIX: No rcparam minor ticks in colorbar #8358 - #10530

Closed
Dih5 wants to merge 3 commits into
matplotlib:masterfrom
Dih5:fix-rcminorticks-colorbar
Closed

Dih5 wants to merge 3 commits into
matplotlib:masterfrom
Dih5:fix-rcminorticks-colorbar

Conversation

Dih5 commented Feb 19, 2018

Copy link
Copy Markdown

PR Summary

Fixes #8358. Minor ticks were shown in colorbars when the ytick.minor.visible rcParam is True. A user won't be regarding a colorbar as a y axis, so this is a bug and not a feature 😉
This PR forces removal of the minor ticks on the axes of a colorbar when its created. A image comparison test is also provided.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak commented Feb 19, 2018

Copy link
Copy Markdown
Member

#9903 also addresses this.

Dih5 commented Feb 19, 2018

Copy link
Copy Markdown
Author

I notice now that minor ticks should not be hidden by default in linear scale, so my fix is not good!
Please, consider checking #8358 is fixed in #9903, that seems proper way to address the problem.

Dih5 closed this Feb 19, 2018

jklymak commented Feb 19, 2018

Copy link
Copy Markdown
Member

Well #9903 is pretty radical change to colorbars so it may not get in. So an interim fix to this problem might be a good idea I don’t have the time to check right now but will try to remember later if #9903 fixes that issue.

Dih5 reopened this Feb 19, 2018

Dih5 commented Feb 19, 2018

Copy link
Copy Markdown
Author

I updated the changes to apply only with Log/SymLog normalizations. I hope for #9903 to make it eventually, but in the meantime perhaps this might solve the issue.

Dih5 commented Mar 23, 2018

Copy link
Copy Markdown
Author

Now that #9903 has been merged, there is no need for this PR. Thanks to @jklymak for this great job 🎉

Dih5 closed this Mar 23, 2018
Dih5 deleted the fix-rcminorticks-colorbar branch March 23, 2018 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor ticks on log-scale colorbar are not cleared

2 participants


Back | FazBrowse Home | New Git URL