Repository navigation
Include template matplotlibrc in package_data. - #11273
Merged
WeatherGod merged 1 commit intoMay 20, 2018
Merged
WeatherGod merged 1 commit into
WeatherGod merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is necessary to make the tests pass for a non-editable install.
Copy link
Copy Markdown
Member
|
Is this file going to be auto-generated before it gets included? I am not exactly sure how this process works in setuptools. |
Sorry, something went wrong.
tacaswell
approved these changes
May 19, 2018
Copy link
Copy Markdown
Contributor
Author
|
@WeatherGod It's always present in the source tree. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
What do you mean? It isn't in the source tree.
https://github.com/matplotlib/matplotlib/tree/master/lib/matplotlib/mpl-data
…On Sat, May 19, 2018 at 4:30 PM, Antony Lee ***@***.***> wrote:
@WeatherGod <https://github.com/WeatherGod> It's always present in the
source tree.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11273 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-Cla722p0Z4QgGrsW15aVXg-PqTgks5t0IDvgaJpZM4UFIV3>
.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Oh sorry, my bad. with open('lib/matplotlib/mpl-data/matplotlibrc', 'w') as fd:
fd.write(
template.safe_substitute(TEMPLATE_BACKEND=default_backend))
and that happens even before setuptools has a chance to look at sys.argv, IOW early enough in the process for things to work. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to make the tests pass for a non-editable install.
Should close #10717 (attn @matthew-brett).
PR Summary
PR Checklist