| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
|
@dstansby Thanks,; new test fails on master, passes on this PR. |
Sorry, something went wrong.
There was a problem hiding this comment.
Seems like a bit of a bodge that should be fixed properly elsewhere, but if it works it works for now.
Sorry, something went wrong.
|
Hmmm, well, the problem is logit transform, which doesnt do sensible things if the values passed to it are not 0<a<1. It has a "clip" argument, but we don't call transforms with clip turned on, so. Conversely, you may not want to always clip data sent to the transform, because maybe you want to tell the user its gone to infinity.... The other solution that occured to me is getting the spine Path to resolve itself properly earlier, but that seemed hard, and unecessary. |
Sorry, something went wrong.
|
I should probably write a similar test for mpl-probscale, which is very similar to logit scales |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Closes #11386; see also #11404 which fixes the errors for tight_layout and constrained_layout.
gives a warning, and does not show the ylabel. Issue is that the yaxis spine path is
Path(array([[ 0., 13.], [ 0., 13.]]), None)and _update_label_position needs a valid path to get started, whereas the logit scale injects Infs.
This PR changes the default PATH to something that would theoretically fit on the figures (and hence all values are less than 1).
PR Checklist