FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

the affine matrix is calculated in the display coordinate for interpolation='none' by leejjoon · Pull Request #1150 · matplotlib/matplotlib · GitHub

Repository navigation

the affine matrix is calculated in the display coordinate for interpolation='none' - #1150

Merged
mdboom merged 3 commits into
matplotlib:masterfrom
leejjoon:fix-image-shift
Sep 5, 2012
Merged

mdboom merged 3 commits into
matplotlib:masterfrom
leejjoon:fix-image-shift

Conversation

Copy link
Copy Markdown
Contributor

For images with interpolation='none', the affine matrix is now calculated in the display coordinate.
This is to simplify the matrix that renderers receives.
This is to address #1085.

pelson commented Sep 2, 2012

Copy link
Copy Markdown
Member

If you have code that was failing, but is now fixed, it would be great to get a test for this new code.

mdboom commented Sep 4, 2012

Copy link
Copy Markdown
Member

I'd love to see this go into 1.2.x. I will try to whip up a test based on #1085 for this.

mdboom commented Sep 4, 2012

Copy link
Copy Markdown
Member

I've added a test as a PR against @leejjoon's branch.

Copy link
Copy Markdown

This pull request fails (merged 67eb71d into 94c53e1).

pelson commented Sep 5, 2012

Copy link
Copy Markdown
Member

+1

mdboom added a commit that referenced this pull request Sep 5, 2012
the affine matrix is calculated in the display coordinate for interpolation='none'
mdboom merged commit 2e5a38a into matplotlib:master Sep 5, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL