FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Raise ImportError on failure to import backends. by anntzer · Pull Request #11519 · matplotlib/matplotlib · GitHub

Repository navigation

Raise ImportError on failure to import backends. - #11519

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:backendloadfailure
Jun 28, 2018
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:backendloadfailure

Conversation

anntzer commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

Breaking down #9795 into smaller pieces.
Marking as release critical following #9795.


This will make backend fallback logic easier (try a backend, if it
raises ImportError, move to the next one).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This will make backend fallback logic easier (try a backend, if it
raises ImportError, move to the next one).
anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 27, 2018
anntzer added this to the v3.0 milestone Jun 27, 2018

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 works as expected for the OSX backend on a non-framework build, someone else should probably check that gtk3 behaves as expected

tacaswell merged commit 939c311 into matplotlib:master Jun 28, 2018
anntzer deleted the backendloadfailure branch June 28, 2018 21:49
tacaswell mentioned this pull request Jul 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL