FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Suppress a spurious missing-glyph warning with ft2font. by anntzer · Pull Request #11605 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Suppress a spurious missing-glyph warning with ft2font. - #11605

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:spurious-ft2font-missing-glyph-warning
Jul 9, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Suppress a spurious missing-glyph warning with ft2font.#11605
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:spurious-ft2font-missing-glyph-warning

Conversation

anntzer commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

FT_Get_Char_Index(face, 0) returns 0; that doesn't warrant a warning.

(aka don't spam the CI with spurious warnings).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Suppress a spurious missing-glyph warning with ft2font.
3ba2e6d 
`FT_Get_Char_Index(face, 0)` returns 0; that doesn't warrant a warning.
anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 9, 2018
anntzer added this to the v3.0 milestone Jul 9, 2018
tacaswell merged commit 7684f0f into matplotlib:master Jul 9, 2018

tacaswell commented Jul 9, 2018

Copy link
Copy Markdown
Member

Thanks @anntzer

anntzer deleted the spurious-ft2font-missing-glyph-warning branch July 9, 2018 13:28
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jul 10, 2018
Revert "Merge pull request matplotlib#11605 from anntzer/spurious-ft2…
db26adf 
…font-missing-glyph-warning"

This reverts commit 7684f0f, reversing
changes made to 9324b27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL