FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Skip wx interactive tests on OSX." by tacaswell · Pull Request #11708 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Revert "Skip wx interactive tests on OSX." - #11708

Closed
tacaswell wants to merge 1 commit into
masterfrom
revert-11593-skiposxwx
ConversationCommits (1)ChecksFiles changed
Closed

Revert "Skip wx interactive tests on OSX."#11708
tacaswell wants to merge 1 commit into
masterfrom
revert-11593-skiposxwx

Conversation

tacaswell commented Jul 19, 2018

Copy link
Copy Markdown
Member

Reverts #11593

Lets see if wx is fixed!

tacaswell modified the milestones: v3.0, v3.1 Jul 19, 2018

tacaswell commented Jul 20, 2018

Copy link
Copy Markdown
Member Author

It now timesout rather than segfaulting which is a step in the right direction!

@DietmarSchwertberger Do you have any suggestions on this one?

tacaswell mentioned this pull request Jul 20, 2018
Closed

DietmarSchwertberger commented Jul 22, 2018

Copy link
Copy Markdown
Contributor

@tacaswell : Please give me a few days to test this on OS X.
Also, it's not clear to me which versions of Python and wxPython and are failing.

DietmarSchwertberger commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

I have just tried in a VM with Python 3.6 and wxPython 4.0.3. For me it seems to work.
As expected, I can trigger a timeout by commenting out the fig.canvas.mpl_connect.....
Maybe the segfaults were related to the old timer implementation where the timer sent events to the frame and the frame got destroyed.

tacaswell closed this Feb 23, 2019
tacaswell deleted the revert-11593-skiposxwx branch February 23, 2019 03:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI: wx

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL