Repository navigation
Fix drawing on qt+retina. - #11712
Merged
efiring merged 1 commit intoJul 20, 2018
Merged
efiring merged 1 commit into
efiring merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jklymak
approved these changes
Jul 20, 2018
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Fixes the issue on my retina screen...
Sorry, something went wrong.
efiring
approved these changes
Jul 20, 2018
efiring
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Now it works on my system.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
OK, I still have issues. If I create a window and resize it a bunch of times, I can eventually get a segmentation fault using QT5Agg. I'm going to guess that is due to this and the previous Qt repaint PR. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_platform.dylib 0x00007fff510d7f49 _platform_memmove$VARIANT$Haswell + 41 1 libQt5Gui.5.dylib 0x000000010f6ddbcd QImage::copy(QRect const&) const + 1629 2 libQt5Gui.5.dylib 0x000000010f6ddec7 QImage::detach() + 103 3 libQt5Gui.5.dylib 0x000000010f6def6c QImage::setDevicePixelRatio(double) + 44 4 QtGui.so 0x000000010f3c4ec8 meth_QImage_setDevicePixelRatio(_object*, _object*) + 104 5 python 0x000000010a05fc68 _PyCFunction_FastCallDict + 200 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
@efiring Can you check whether this fixes #11709?
PR Checklist