FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix cairo's image inversion and alpha misapplication. by anntzer · Pull Request #11724 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix cairo's image inversion and alpha misapplication. - #11724

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:fix-cairo-image
Jul 26, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Fix cairo's image inversion and alpha misapplication.#11724
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:fix-cairo-image

Conversation

anntzer commented Jul 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Closes #8798. Looks like people are actually using the backend and running into the bug :p
I guess this would be nice to have in 3.0 (as it fixes a pretty bad bug) but won't insist on it either.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added this to the v3.0 milestone Jul 21, 2018

jklymak commented Jul 26, 2018

Copy link
Copy Markdown
Member

So there is no test for this?

anntzer commented Jul 26, 2018

Copy link
Copy Markdown
Contributor Author

No CI.

jklymak merged commit a373dc3 into matplotlib:master Jul 26, 2018
anntzer deleted the fix-cairo-image branch July 26, 2018 22:18
ImportanceOfBeingErnest mentioned this pull request Sep 16, 2018
Closed

jklymak commented Sep 27, 2018

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.2.x

lumberbot-app Bot commented Sep 27, 2018

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 a373dc3d1a4bede2803f02ca4d82336cc19da9e4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am "Backport PR #11724: Fix cairo's image inversion and alpha misapplication."
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-11724-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #11724 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jklymak modified the milestones: v3.0, v2.2.4 Sep 27, 2018
tacaswell modified the milestones: v2.2.4, v2.2.5 Sep 5, 2019
tacaswell modified the milestones: v2.2.5, v3.0.0 Feb 17, 2020

tacaswell commented Feb 17, 2020

Copy link
Copy Markdown
Member

This did not get backported to 2.2.x, but did make it in to 3.0.0, re-milestoned as such.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
jklymak jklymak approved these changes

Assignees

No one assigned

Labels

backend: cairo

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

gtk3cairo draw_image does not respect origin and mishandles alpha

3 participants

Back | FazBrowse Home | New Git URL