FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Directly get the size of the renderer buffer from the renderer. by anntzer · Pull Request #11731 · matplotlib/matplotlib · GitHub

Repository navigation

Directly get the size of the renderer buffer from the renderer. - #11731

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:qt-buffer-off-by-one
Jul 22, 2018
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:qt-buffer-off-by-one

Conversation

anntzer commented Jul 21, 2018

Copy link
Copy Markdown
Contributor

... rather than trying to compute it outselves, which can lead to
off-by-one errors due to the use of floats in the initial buffer
request.

Closes #11728.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... rather than trying to compute it outselves, which can lead to
off-by-one errors due to the use of floats in the initial buffer
request.
anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: Qt labels Jul 21, 2018
anntzer added this to the v3.0 milestone Jul 21, 2018

jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This fixes the resize issue I had...

tacaswell merged commit 23420a4 into matplotlib:master Jul 22, 2018
anntzer deleted the qt-buffer-off-by-one branch July 22, 2018 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI: Qt Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qt5 Segfaults on window resize

3 participants


Back | FazBrowse Home | New Git URL