FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Derive plt.figlegend.__doc__ from Figure.legend.__doc__. by anntzer · Pull Request #11975 · matplotlib/matplotlib · GitHub

Repository navigation

Derive plt.figlegend.__doc__ from Figure.legend.__doc__. - #11975

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:figlegend-docstring
Sep 1, 2018
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:figlegend-docstring

Conversation

anntzer commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

Sure, we lose the .. seealso:: to pyplot.legend. I think that's a fair
tradeoff as the new docstring is much more precise.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Sure, we lose the .. seealso:: to pyplot.legend.  I think that's a fair
tradeoff as the new docstring is much more precise.
tacaswell added this to the v3.1 milestone Aug 30, 2018
jklymak merged commit a3dc2e1 into matplotlib:master Sep 1, 2018
anntzer deleted the figlegend-docstring branch September 1, 2018 08:55
ksunden mentioned this pull request Nov 12, 2022
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL