FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix AttributeError in GTK3Agg backend by akhilman · Pull Request #12016 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix AttributeError in GTK3Agg backend - #12016

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
akhilman:fix-gtk3agg-attribute-error
Sep 5, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Fix AttributeError in GTK3Agg backend#12016
timhoffm merged 1 commit into
matplotlib:masterfrom
akhilman:fix-gtk3agg-attribute-error

Conversation

akhilman commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Fixes #12015

PR Summary

backend_cairo has not _unmultipled_rgba8888_to_premultiplied_argb32 attribute, but cbook does.
Examples doesn't work without this patch, but works well with it.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm approved these changes Sep 5, 2018
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, and congratulation to your first contribution to matplotlib!

timhoffm commented Sep 5, 2018

Copy link
Copy Markdown
Member

Regression from #11845.

timhoffm added this to the v3.0 milestone Sep 5, 2018
timhoffm added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2018
timhoffm merged commit 248399e into matplotlib:master Sep 5, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 5, 2018
Backport PR matplotlib#12016: Fix AttributeError in GTK3Agg backend
b7aa194
meeseeksmachine mentioned this pull request Sep 5, 2018
Merged

anntzer commented Sep 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Now the real question is why flake8 didn't catch this...
I guess it doesn't check for names defined in other modules?

anntzer mentioned this pull request Sep 5, 2018
Merged
6 tasks
dstansby added a commit that referenced this pull request Sep 5, 2018
Merge pull request #12017 from meeseeksmachine/auto-backport-of-pr-12…
56ee1b2 
…016-on-v3.0.x

Backport PR #12016 on branch v3.0.x (Fix AttributeError in GTK3Agg backend)
akhilman deleted the fix-gtk3agg-attribute-error branch September 5, 2018 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

AttributeError with GTK3Agg backend

4 participants

Back | FazBrowse Home | New Git URL