Repository navigation
MAINT: Vectorize bar3d - #12137
Merged
QuLogic merged 5 commits intoSep 24, 2018
Merged
MAINT: Vectorize bar3d #12137QuLogic merged 5 commits into
QuLogic merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Brought-on to try and determine if faces are clockwise-ordered or counter-clockwise-ordered
eric-wieser
force-pushed
the
bar3d-simplify
branch
from
dcc48e4 to
5314244
Compare
September 17, 2018 00:23
eric-wieser
force-pushed
the
bar3d-simplify
branch
from
5314244 to
f44b437
Compare
September 17, 2018 00:26
Copy link
Copy Markdown
Contributor
Author
|
Flake8 failures seem to not be part of this patch? ./lib/mpl_toolkits/mplot3d/axes3d.py:1692:80: E501 line too long (84 > 79 characters) ./lib/mpl_toolkits/mplot3d/axes3d.py:1705:80: E501 line too long (83 > 79 characters) 2 E501 line too long (84 > 79 characters) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Style issue is fixed by #12139, feel free to rebase on top of it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Too lazy to do that. I'll just close and re-open this PR once that one is merged to restart CI |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
CI now passes - thanks! |
Sorry, something went wrong.
dstansby
approved these changes
Sep 24, 2018
QuLogic
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors bar3d to use numpy to compute all the coordinates in parallel.
I'm not certain if this actually results in a speed increase, but it does result in a clarity improvement,
This spun out of #12136, which raised the fact that bar3d does not orient its faces correctly (#12138). This patch does not fix that, but it does make it easy to fix in a subsequent revision.
I can split the multiple commits here into multiple PRs if that adds value.