Repository navigation
Deprecate \stackrel. - #12150
Merged
jklymak merged 1 commit intoFeb 22, 2019
Merged
Deprecate \stackrel.#12150jklymak merged 1 commit into
jklymak merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
stackrel
branch
2 times, most recently
from
90b3bc1 to
cec36cd
Compare
October 5, 2018 14:17
jklymak
approved these changes
Feb 10, 2019
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Fine w/ me. Doubt this is the most heavily used corner of the codebase...
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
rebased |
Sorry, something went wrong.
Mathtext's \stackrel{a}{b} behaves subtly differently from latex's
\stackrel{a}{b}: mathtext makes `a` and `b` equal-sized whereas latex
makes `a` smaller than `b` (`a` is an "annotation" over `b`). Given
that we can already stack expressions using the (admittedly less
practical, but standard) \genfrac, just deprecate \stackrel instead of
maintaining our own latex-like dialect.
Also undeprecate passing obj_type to the cbook.deprecated decorator(!),
given that this PR has a good reason to use it... and while we're at it,
reorder the kwargs docs for cbook.deprecated and cbook.warn_deprecated
to match the order in the signature.
timhoffm
reviewed
Feb 10, 2019
timhoffm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Subject to CI pass.
Sorry, something went wrong.
timhoffm
approved these changes
Feb 10, 2019
timhoffm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Subject to CI pass.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI failures unrelated... |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathtext's \stackrel{a}{b} behaves subtly differently from latex's
\stackrel{a}{b}: mathtext makes a and b equal-sized whereas latex
makes a smaller than b (a is an "annotation" over b). Given
that we can already stack expressions using the (admittedly less
practical, but standard) \genfrac, just deprecate \stackrel instead of
maintaining our own latex-like dialect.
Also undeprecate passing obj_type to the cbook.deprecated decorator(!),
given that this PR has a good reason to use it... and while we're at it,
reorder the kwargs docs for cbook.deprecated and cbook.warn_deprecated
to match the order in the signature.
Again related to #12108 / #12128 (:mathmpl: still exists because mathtext is subtly different from latex).
PR Summary
PR Checklist