Repository navigation
FIX: colorbar re-check norm before draw for autolabels - #12159
Merged
dstansby merged 2 commits intoOct 17, 2018
Merged
dstansby merged 2 commits into
dstansby merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
If config_axis is now called within draw_all, one can get rid of it inside of __init__ matplotlib/lib/matplotlib/colorbar.py Lines 408 to 409 in 2c77256 and update_bruteforce I guess matplotlib/lib/matplotlib/colorbar.py Lines 1153 to 1154 in 2c77256 |
Sorry, something went wrong.
jklymak
force-pushed
the
fix-check-norm-autolabels
branch
2 times, most recently
from
0efbd3a to
e10954c
Compare
September 19, 2018 02:30
jklymak
force-pushed
the
fix-check-norm-autolabels
branch
2 times, most recently
from
e891183 to
6e34845
Compare
September 20, 2018 17:53
dstansby
approved these changes
Sep 24, 2018
tacaswell
approved these changes
Oct 15, 2018
tacaswell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
modulo a rebase and tests passing.
Sorry, something went wrong.
jklymak
force-pushed
the
fix-check-norm-autolabels
branch
2 times, most recently
from
cda498c to
a4e33cf
Compare
October 15, 2018 19:47
FIX: properly set x/y limits MNT: add tolerance to colorbar locator methods
jklymak
force-pushed
the
fix-check-norm-autolabels
branch
from
a4e33cf to
3add532
Compare
October 15, 2018 20:02
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 17, 2018
… for autolabels
dstansby
added a commit
that referenced
this pull request
Oct 17, 2018
…159-on-v3.0.x Backport PR #12159 on branch v3.0.x (FIX: colorbar re-check norm before draw for autolabels)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #12155
If a user changes the norm on a colorbar from a linear to logarithmic, we were not changing the scale of the colorbar axes to a logarithmic scale. That needs to be done after #9903 because we now use normal locators for colorbar axes.
PR Checklist