FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Modify the bar3d test to show three more angles by eric-wieser · Pull Request #12292 · matplotlib/matplotlib · GitHub

Repository navigation

TST: Modify the bar3d test to show three more angles - #12292

Merged
WeatherGod merged 1 commit into
matplotlib:masterfrom
eric-wieser:bar3d-subplot-tests
Sep 26, 2018
Merged

WeatherGod merged 1 commit into
matplotlib:masterfrom
eric-wieser:bar3d-subplot-tests

Conversation

eric-wieser commented Sep 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This shows the effect of #12138, where the two brightest faces are opposite each other.

An alternate to #12273, which uses multiple subplots

This shows the effect of matplotlib#12138, where the two brightest faces are opposite each other.

Copy link
Copy Markdown
Member

👍 I think this looks good to me!

dstansby added this to the v3.1 milestone Sep 26, 2018

Copy link
Copy Markdown
Member

Is the plan to merge this and then rebase the other one so we can better see the difference?

Copy link
Copy Markdown
Contributor Author

@WeatherGod: Yes, exactly

WeatherGod merged commit 5e1133b into matplotlib:master Sep 26, 2018
eric-wieser deleted the bar3d-subplot-tests branch March 23, 2019 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL