Repository navigation
colorbar optionally uses GridSpecFromSubplotSpec to create cax - #126
Merged
leejjoon merged 2 commits intoJun 9, 2011
Merged
leejjoon merged 2 commits into
leejjoon merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
lib/matplotlib/colorbar.py
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I assume you didn't intend to leave this print statement in.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
That is now fixed with 02fbdbc. Thanks.
Sorry, something went wrong.
leejjoon
added a commit
that referenced
this pull request
Jun 9, 2011
--- When pyplot.colorbar is called (w/ cax=None), it modifies the position of the parent axes and creates a new axes (cax) for a colorbar. However, issues can arise if the parent axes is an instance of Subplot because cax is created as an instance of Axes. This patch introduces a new keyword parameter "use_gridspec". If True (default is False) and if the parent axes is an instance of Subplot, cax is created also as an instance of Subplot. This patch is partly motivated to support tight_layout. Since cax is a subplot, tight_layout works.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pyplot.colorbar is called (w/ cax=None), it modifies the position of the parent axes and creates a new axes (cax) for a colorbar. However, issues can arise if the parent axes is an instance of Subplot because cax is created as an instance of Axes.
This patch introduces a new keyword parameter "use_gridspec". If True (default is False) and if the parent axes is an instance of Subplot, cax is created also as an instance of Subplot.
This patch is partly motivated to support tight_layout. Since cax is a subplot, tight_layout works.