Repository navigation
FIX: allow non bbox_extra_artists calls - #12635
timhoffm merged 2 commits into
Conversation
Sorry, something went wrong.
|
Note I still need to add a test or two. This shouldn’t have passed CI (EDIT: shuld not have passed CI when the original PR went in)... EDIT: test added! |
Sorry, something went wrong.
…635-on-v3.0.x Backport PR #12635 on branch v3.0.x (FIX: allow non bbox_extra_artists calls)
| grid[i].set_title('test {0}{0}'.format(i)) | ||
|
|
||
|
|
||
| def test_gettightbbox(): |
There was a problem hiding this comment.
Have you looked at the figure produced in this test? Is it working the way it's supposed to? I get one Axes with one really big Axes overlaid on top of it, but I'm not sure if that's the intended behaviour or not.
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, sorry, its not a very good test. But I'm not sure why axes_grid does that, so that's a different issue. The issue here was that the png being made was not being cropped properly to include the big box when bbox_inches='tight' was used.
Sorry, something went wrong.
PR Summary
Closes #12634
Apparently some axes don't allow accept bbox_extra_artists kwarg. I could not track down how to get the parasite axes' get_tightbbox to accept this kwarg, but this fix seems to work fine.
The offending PR was #12363 where I introduced the bbox_extra_artists as a kwarg. That was probably a mistake because some axes subclasses out there may not impliment this kwarg.
This PR makes that kwarg optional - if axsubclass.get_tightbbox(renderer, bbox_extra_artists=artists) gives a TypeError, then we just call it w/o this kwarg.
PR Checklist