Repository navigation
Rename tkinter import from Tk to tk. - #12704
Merged
timhoffm merged 1 commit intoNov 4, 2018
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timhoffm
approved these changes
Nov 1, 2018
tacaswell
approved these changes
Nov 4, 2018
Copy link
Copy Markdown
Member
|
This has conflicts, presumably from #12707 |
Sorry, something went wrong.
Currently we `import tkinter as Tk`, which is a bit confusing as there is also a `tkinter.Tk` class (for example, both `tkinter.mainloop` -- currently aliased as `Tk.mainloop` -- and `tkinter.Tk.mainloop` exist). Instead, `import tkinter as tk`; this shorthand is also consistent with the tkinter docs (https://docs.python.org/3/library/tkinter.html).
Copy link
Copy Markdown
Contributor
Author
|
rebased |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we import tkinter as Tk, which is a bit confusing as there
is also a tkinter.Tk class (for example, both tkinter.mainloop --
currently aliased as Tk.mainloop -- and tkinter.Tk.mainloop exist).
Instead, import tkinter as tk; this shorthand is also consistent with
the tkinter docs (https://docs.python.org/3/library/tkinter.html).
Noted while investigating #12703.
PR Summary
PR Checklist