FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove logic for optionally building Agg and TkAgg. by anntzer · Pull Request #13075 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Remove logic for optionally building Agg and TkAgg. - #13075

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:force-agg-tkagg
Nov 6, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Remove logic for optionally building Agg and TkAgg.#13075
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:force-agg-tkagg

Conversation

anntzer commented Jan 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

They are actually not optional (that's the force = True setting which
overrides the OptionalBackendPackage logic), so just make them
SetupPackages and remove the corresponding (outdated) comments in
setup.cfg.template.

Builds on top of #13074 as the prose in setup.cfg.template is only true if we also remove windowing from there. [edit: that PR has been merged]

(The OptionalBackendPackage logic was also previously useful back when the default backend was selected at build time, but that's no longer the case.)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added the Build label Jan 1, 2019
anntzer force-pushed the force-agg-tkagg branch 2 times, most recently from 2b3ba13 to d6aaaee Compare January 1, 2019 23:26

tacaswell commented Jan 3, 2019

Copy link
Copy Markdown
Member

Would it be better to actually make tkagg optional?

tacaswell added this to the v3.1 milestone Jan 3, 2019

anntzer commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

It's been non-optional for years and no one complained; what would be the use case? Note that the build doesn't depend on any external headers or libraries.

anntzer commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

(In fact I'm tempted to also make the OSX backend non-optional if someone can verify whether the cocoa headers are always installed with xcode...)

FRidh mentioned this pull request Feb 21, 2019
Merged
10 tasks
tacaswell modified the milestones: v3.1.0, v3.2.0 Feb 23, 2019

tacaswell commented Feb 23, 2019

Copy link
Copy Markdown
Member

punting to 3.2 as it has conflicts, in non-critical, and the fiddly to make sure we got it right.

anntzer commented Feb 24, 2019

Copy link
Copy Markdown
Contributor Author

Rebased. Once again, note that always forcing the build of tkagg (which does not depend on the tk headers) has been the actual behavior for years now.

anntzer force-pushed the force-agg-tkagg branch from be1a25b to ac3d800 Compare May 27, 2019 09:08
anntzer mentioned this pull request Jun 4, 2019
Merged
6 tasks
anntzer mentioned this pull request Jul 2, 2019
Merged
6 tasks
tacaswell modified the milestones: v3.2.0, v3.3.0 Aug 24, 2019

QuLogic commented Nov 3, 2019

Copy link
Copy Markdown
Member

It seems that moving Travis means I can't restart the broken build, so you'll have to rebase.

Remove logic for optionally building Agg and TkAgg.
babe80b 
They are actually not optional (that's the `force = True` setting which
overrides the OptionalBackendPackage logic), so just make them
SetupPackages and remove the corresponding (outdated) comments in
setup.cfg.template.

anntzer commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

rebased, build passes

WeatherGod commented Nov 4, 2019 via email

Copy link
Copy Markdown
Member

anntzer commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

The tkagg build doesn't interact with tk at build time whatsoever since #6442. Quoting from that PR:

It is one way of building a manylinux wheel that can build on a basic Manylinux docker image (i.e. without tk -- this comment is mine), and then run with the TCL / Tk library installed on the installing user's machine.

timhoffm approved these changes Nov 5, 2019
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seem reasonable. Should we want optional Agg at some point, we can always reintroduce it. For now this is a simplification of the setup code.

QuLogic merged commit 5495b88 into matplotlib:master Nov 6, 2019
anntzer deleted the force-agg-tkagg branch November 6, 2019 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL