Repository navigation
Fix plot_basedir bug in sphinxext - #132
Merged
ddale merged 2 commits intoJun 16, 2011
Merged
ddale merged 2 commits into
ddale merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
lib/matplotlib/sphinxext/plot_directive.py
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Don't comment out old code. The version control system will help us remember what it used to be.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks mostly good. Have you tried building the matplotlib and numpy docs (from numpy's git master) with this patch? Do they still build? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah they build fine, as far as I can tell. |
Sorry, something went wrong.
ddale
added a commit
that referenced
this pull request
Jun 16, 2011
Fix plot_basedir bug in sphinxext
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problems I described here [1] when the plots source directory is above the directory containing conf.py and is named plots. Comments welcome.
[1] http://thread.gmane.org/gmane.comp.python.matplotlib.devel/10224