FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Interpret unitless bar widths for unitized data as relative to spacing. by anntzer · Pull Request #13254 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Interpret unitless bar widths for unitized data as relative to spacing. - #13254

Closed
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:bar-units
ConversationCommits (1)ChecksFiles changed
Closed

Interpret unitless bar widths for unitized data as relative to spacing.#13254
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:bar-units

Conversation

anntzer commented Jan 21, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Implements the proposal in #13236.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer mentioned this pull request Jan 21, 2019
Open

anntzer commented Jan 21, 2019

Copy link
Copy Markdown
Contributor Author

So this actually breaks some tests that were doing

bar([3, 4, 5], ["foo", "bar", "baz"])

and expected to get

which is pretty nonsensical IMO (with this PR, this fails when trying to add 0 (bottom) to "foo").
Obviously there's backcompat concerns (also for the case of units that's don't define addition -- there's an example in the docs (see the circleci failure), but I'd argue this doesn't really make sense either). Thoughts?

jklymak mentioned this pull request Jan 23, 2019
Merged
6 tasks

jklymak commented Apr 23, 2021

Copy link
Copy Markdown
Member

Is this still needed after #12903? I'm closing, but feel free to request a reopen

jklymak closed this Apr 23, 2021

anntzer commented Apr 23, 2021

Copy link
Copy Markdown
Contributor Author

I think this was attempting to solve a different problem, but well, units...

anntzer deleted the bar-units branch April 23, 2021 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic: units and array ducktypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL