Repository navigation
Numpyfy tick handling code in Axis3D. - #13364
Merged
dstansby merged 1 commit intoJul 21, 2019
Merged
dstansby merged 1 commit into
dstansby merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
WeatherGod
approved these changes
Feb 6, 2019
WeatherGod
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good and seems to reduce complexity significantly. Just want to make sure the setters that got modified are going to broadcast properly.
Sorry, something went wrong.
Comment thread
lib/mpl_toolkits/mplot3d/axis3d.py
| self.gridlines.set_segments(lines) | ||
| self.gridlines.set_color(info['grid']['color']) | ||
| self.gridlines.set_linewidth(info['grid']['linewidth']) | ||
| self.gridlines.set_linestyle(info['grid']['linestyle']) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
do we know if these setters are properly broadcasting the scalars?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
At least manually setting a scalar into any of these works.
Sorry, something went wrong.
dstansby
approved these changes
Jul 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Depends on #13363 (now merged).
PR Checklist