Repository navigation
Raise NotImplementedError with equal aspect on 3D axes - #13474
Merged
timhoffm merged 1 commit intoFeb 21, 2019
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
reviewed
Feb 20, 2019
Comment thread
lib/matplotlib/axes/_base.py
Outdated
jklymak
reviewed
Feb 20, 2019
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Another option is to warn or log.info.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
(I'm in favor of actually throwing an exception, given that the resulting plot is just plain wrong.) |
Sorry, something went wrong.
dstansby
force-pushed
the
3d-equal-aspect
branch
from
47a3d86 to
29b048f
Compare
February 20, 2019 20:30
anntzer
approved these changes
Feb 21, 2019
Copy link
Copy Markdown
Member
|
I meant warn and not set the aspect ratio, not warn and do something buggy 😉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Right now we raise if someone does set_aspect("foobar"); I think passing "equal" to 3D axes is essentially the same. |
Sorry, something went wrong.
timhoffm
approved these changes
Feb 21, 2019
kip-hart
pushed a commit
to kip-hart/MicroStructPy
that referenced
this pull request
Sep 12, 2019
ftherrien
pushed a commit
to ftherrien/p2ptrans
that referenced
this pull request
Jan 15, 2020
The NotImplemented error was caused by the fact that set_aspect now causes an error in matplotlib (see matplotlib/matplotlib#1077 and matplotlib/matplotlib#13474). Fixed by making the figure itself square such that the 3D axis are square. Also change the fortan module's name from p2ptrans to fmodules which prevented from importing p2ptrans as a python module.
SenorPez
added a commit
to SenorPez/glowing-potato
that referenced
this pull request
Jan 28, 2020
This was referenced Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1077. Until it is implemented properly, it seems reasonable to raise a NotImplementedError (and not a warning, because trying to set an equal aspect results in nonsense: #1077 (comment))