FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix IndexError for pyplot.legend() when plotting empty bar chart with label by choyiny · Pull Request #13551 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix IndexError for pyplot.legend() when plotting empty bar chart with label #13551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklymak merged 3 commits into from
Mar 2, 2019
Conversation 7 Commits 3 Checks 0 Files changed
Merged

Fix IndexError for pyplot.legend() when plotting empty bar chart with label #13551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ae61a
FIX: legend crashes when bar chart is empty with label
choyiny Feb 28, 2019
33d8f8e
add test with generating legend with empty bar chart
choyiny Mar 2, 2019
528bb02
remove image_comparison from legend test case
choyiny Mar 2, 2019
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 3 additions & 1 deletion lib/matplotlib/legend_handler.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ def legend_artist(self, legend, orig_handle, fontsize, handlebox)


def update_from_first_child(tgt, src):
tgt.update_from(src.get_children()[0])
first_child = next(iter(src.get_children()), None)
if first_child is not None:
tgt.update_from(first_child)


class HandlerBase(object):
Expand Down
8 changes: 8 additions & 0 deletions lib/matplotlib/tests/test_legend.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,14 @@ def test_handler_numpoints():
ax.legend(numpoints=0.5)


def test_empty_bar_chart_with_legend():
"""Test legend when bar chart is empty with a label."""
# related to issue #13003. Calling plt.legend() should not
# raise an IndexError.
plt.bar([], [], label='test')
plt.legend()


def test_shadow_framealpha():
# Test if framealpha is activated when shadow is True
# and framealpha is not explicitly passed'''
Expand Down
Back | FazBrowse Home | New Git URL