FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes incorrect error bar colors when NaN values are present by kasanitej · Pull Request #13825 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fixes incorrect error bar colors when NaN values are present - #13825

Closed
kasanitej wants to merge 3 commits into
matplotlib:masterfrom
kasanitej:Pull/13799
ConversationCommits (3)ChecksFiles changed
Closed

Fixes incorrect error bar colors when NaN values are present#13825
kasanitej wants to merge 3 commits into
matplotlib:masterfrom
kasanitej:Pull/13799

Conversation

kasanitej commented Apr 1, 2019

Copy link
Copy Markdown

PR Summary

incorrect error bar colors when NaN values are present
#13799

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic commented Apr 1, 2019

Copy link
Copy Markdown
Member

Please give your PRs descriptive titles; what does this change do?

kasanitej commented Apr 10, 2019

Copy link
Copy Markdown
Author

Hi,

This PR pertains to issue reported in #13799.

My change will look into the corresponding index of the color of X & Y where there are np.nan, and remove them.

Regards,
Bhanu.

anntzer commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

I think(??) the correct fix is to keep the invalid values in everywhere but not plot them, similarly to #12422.

kasanitej commented Apr 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

yeah.. that's sound better than removing them. I will check it. Thanks for suggestion.

NelleV changed the title Pull/13799 Fixes incorrect error bar colors when NaN values are present Apr 10, 2019

NelleV commented Apr 10, 2019

Copy link
Copy Markdown
Member

I would also raise a warning.

jklymak commented Jul 23, 2020

Copy link
Copy Markdown
Member

Superseded by #16724

jklymak closed this Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL