Repository navigation
MAINT: small improvements to the pdf backend - #14413
jkseppan merged 7 commits into
Conversation
Sorry, something went wrong.
Instead of the `self.nextFoo` counters. This way the various name sequences are defined closer together and it's impossible to forget to increment the counters.
draw_markers has been implemented, draw_line_collection was removed years ago but draw_quad_mesh could be implemented
and delete a useless comment
|
|
||
| self.fontNames = {} # maps filenames to internal font names | ||
| self.nextFont = 1 # next free internal font name | ||
| self.internalFontName = (Name(f'F{i}') for i in itertools.count(1)) |
There was a problem hiding this comment.
I don't really mind the API break (it's clearly intended to be a private API), but please add an API change note and make the new APIs private.
Sorry, something went wrong.
| ---------- | ||
|
|
||
| id : int | ||
| object id of the stream |
There was a problem hiding this comment.
| object id of the stream | |
| Object id of the stream. |
Generally, parameter descriptions should start with a capital letter and finish with a period, even if they are not complete sentences.
(Also in the following docs).
Sorry, something went wrong.
| for `'Creator'`, `'Producer'` and `'CreationDate'`. They | ||
| can be removed by setting them to `None`. | ||
| """ | ||
| self.objectId = itertools.count(1) # consumed by reserveObject |
There was a problem hiding this comment.
Maybe better name this
| self.objectId = itertools.count(1) # consumed by reserveObject | |
| self._object_id_generator = itertools.count(1) # consumed by reserveObject |
?
Sorry, something went wrong.
There was a problem hiding this comment.
I gave the new names _seq suffixes to keep the lines slightly shorter.
Sorry, something went wrong.
and name the new members like _foo_seq to make them obviously private and to conform to PEP8
The pytest version requirement has changed.
|
Not a huge deal here, but note that we normally wait for approval from two reviewers (other than the PR author) to merge (except for docs-only changes where one reviewer is enough). |
Sorry, something went wrong.
|
Oops, sorry! I'll be less hasty in the future. -Jouni
|
Sorry, something went wrong.
|
No worries :) |
Sorry, something went wrong.
PR Summary
Improve some docstrings and comments, use generators instead of keeping nextFoo style counters
PR Checklist