Repository navigation
Fix out of bounds read in backend_tk. - #14461
Merged
tacaswell merged 1 commit intoJun 7, 2019
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Really, we should specify somewhere how rounding of bboxes passed to blit() (and to copy_from_bbox()) works, but at least this patch will avoid out-of-bounds reads in the tk blit.
WeatherGod
approved these changes
Jun 6, 2019
WeatherGod
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
makes sense as a sanitation measure. A little concerned that out-of-bounds stuff can happen, but it is probably benign.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
As an extra layer of protection one could raise an error in mpl_tk_blit if any values are out of bounds, e.g. height < y2 or x1 < 0 etc. |
Sorry, something went wrong.
QuLogic
approved these changes
Jun 6, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 7, 2019
Copy link
Copy Markdown
Member
|
I will follow up with a PR at the c level. |
Sorry, something went wrong.
timhoffm
added a commit
that referenced
this pull request
Jun 7, 2019
…461-on-v3.1.x Backport PR #14461 on branch v3.1.x (Fix out of bounds read in backend_tk.)
7 tasks
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really, we should specify somewhere how rounding of bboxes passed to
blit() (and to copy_from_bbox()) works, but at least this patch will
avoid out-of-bounds reads in the tk blit.
@aliaa @cgohlke I think this closes #14225, can you confirm?
PR Summary
PR Checklist