Repository navigation
Improve font weight guessing. - #14483
Merged
QuLogic merged 1 commit intoJun 8, 2019
Merged
QuLogic merged 1 commit into
QuLogic merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Should probably get a short API change note. |
Sorry, something went wrong.
Previously, we would guess that "Times New Roman Bold" is a regular weight font because its name contains the substring "Roman", even though the font correctly sets the BOLD flag (FT_STYLE_FLAG_BOLD). Invert the logic to give priority to the flag, as its presence is clearly more robust than a substring check. `s.find(w) >= 0` is just an obfuscated way to write `w in s`, so change that.
Copy link
Copy Markdown
Contributor
Author
|
sure, done |
Sorry, something went wrong.
dstansby
approved these changes
Jun 7, 2019
QuLogic
approved these changes
Jun 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would guess that "Times New Roman Bold" is a regular
weight font because its name contains the substring "Roman", even though
the font correctly sets the BOLD flag (FT_STYLE_FLAG_BOLD). Invert the
logic to give priority to the flag, as its presence is clearly more
robust than a substring check.
s.find(w) >= 0 is just an obfuscated way to write w in s, so change
that.
Obviously font properties extraction could be improved in a lot of ways, but this should close #5574.
PR Summary
PR Checklist