FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Docs: Don’t warn for unused ignores by alexrudy · Pull Request #15043 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix Docs: Don’t warn for unused ignores - #15043

Merged
ImportanceOfBeingErnest merged 1 commit into
matplotlib:masterfrom
alexrudy:fix-nitpick
Aug 13, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Fix Docs: Don’t warn for unused ignores#15043
ImportanceOfBeingErnest merged 1 commit into
matplotlib:masterfrom
alexrudy:fix-nitpick

Conversation

alexrudy commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Warnings emitted for unused nitpick ignores were causing CI to fail a lot, and are hard to track down and fix. This should remove that pain.

See issue #15042

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell added this to the v3.2.0 milestone Aug 12, 2019

ImportanceOfBeingErnest commented Aug 12, 2019

Copy link
Copy Markdown
Member

Maybe I do not understand this; but aren't unused ignores actually nice to have warnings about? Those are the ones that are easily fixed.

tacaswell approved these changes Aug 12, 2019
View reviewed changes

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am in favor of merging this to reduce the amount of thrashing we have while we sort out how to use this tool most effectively.

Particularly as @ImportanceOfBeingErnest reports that some of these may be coming from sphinx gallery.

tacaswell mentioned this pull request Aug 12, 2019
Closed

ImportanceOfBeingErnest commented Aug 13, 2019

Copy link
Copy Markdown
Member

Just to say, I'm not convinced anymore that sphinx_gallery has anything to do with those. What I was seeing is due to an error (maybe windows related? or maybe it cannot be used locally?).

ImportanceOfBeingErnest approved these changes Aug 13, 2019
View reviewed changes

ImportanceOfBeingErnest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I do by now think we need to ignore the unused ignores to come to a point where everything is stable again.

ImportanceOfBeingErnest merged commit 96c7c51 into matplotlib:master Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL