FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support for shorthand hex colors. by PatrickFeiring · Pull Request #15152 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Support for shorthand hex colors. - #15152

Merged
NelleV merged 2 commits into
matplotlib:masterfrom
PatrickFeiring:shorthand-hex-colors
Aug 31, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Support for shorthand hex colors.#15152
NelleV merged 2 commits into
matplotlib:masterfrom
PatrickFeiring:shorthand-hex-colors

Conversation

PatrickFeiring commented Aug 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Added support for shorthand hex colors as described in section 4.2 of the current CSS Color Module Level 4 Working Draft from 5 March 2019.

Examples:
#⁠123 is interpreted as #⁠112233
#⁠123a is interpreted as #⁠112233aa

It is a minor change, and I did this mainly to match expectations for anyone coming from web design (myself including) and to make tasks like specifying softer blacks like #⁠333 or greys like #⁠ccc quicker.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

dstansby commented Aug 28, 2019

Copy link
Copy Markdown
Member

Looks good to me - could you add a quick note in /doc/users/next_whats_new to advertise the new feature?

anntzer commented Aug 28, 2019

Copy link
Copy Markdown
Contributor

For reference this is defined at https://www.w3.org/TR/css-color-4/#hex-notation. Likely https://matplotlib.org/tutorials/colors/colors.html and a few other places will also need updating.

jklymak added this to the v3.3.0 milestone Aug 28, 2019

PatrickFeiring commented Aug 30, 2019

Copy link
Copy Markdown
Contributor Author

I added a line about the change in the colors.py and in the color specification tutorial, as well as a new entry in /doc/users/next_whats_new.

dstansby approved these changes Aug 30, 2019
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 thanks for the PR!

anntzer commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

A link to the css spec (e.g. the one I posted above) in colors.py would be nice. (Probably not necessary in the tutorial as well.)

PatrickFeiring changed the title Added support for shorthand hex colors. Support for shorthand hex colors. Aug 30, 2019

NelleV commented Aug 31, 2019

Copy link
Copy Markdown
Member

👍 Thanks @PatrickFeiring !

NelleV merged commit b12a3a8 into matplotlib:master Aug 31, 2019
tacaswell modified the milestones: v3.3.0, v3.2.0 Sep 1, 2019

tacaswell commented Sep 1, 2019

Copy link
Copy Markdown
Member

re-milestoned to 3.2 as we have not branched yet so it's going to be in 3.2 not 3.3.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jul 9, 2020
DOC: Mention shorthand hex RGB(A) in color demo.
cd7ed94 
cf matplotlib#15152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dstansby dstansby approved these changes

Assignees

No one assigned

Labels

topic: color/color & colormaps

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL