FIX: indexed pandas bar by jklymak · Pull Request #15166 · matplotlib/matplotlib · GitHub

PR Summary

basically if you do df = pd.DataFrame({"x":[1,2,3],"width":[.2,.4,.6]},index=[1,2,3]), then df.x[0] errors because that index doesn't exist, which breaks bar.

While I appreciate this is a bit more code than trying to call iat(0), which is what we did before, this solution doesn't presuppose iat exists.

import pandas as pd
from matplotlib import pyplot as plt
import numpy as np

df = pd.DataFrame({"x":[1.,2.,3.],"width":[.2,.4,.6]}, index=[1, 2, 3])
plt.figure()
plt.bar(df.x, 1., width=df.width)
plt.savefig('/Users/jklymak/downloads/Test1.png')

df = pd.DataFrame({"x":[1,3,10]},index=[1000,2000,3000])

plt.figure()
plt.bar(df.x, 1, width=.2)
plt.savefig('/Users/jklymak/downloads/Test2.png')

Now yields the expected (and pre 3.1.0):

PR Checklist

Has Pytest style unit tests
Code is Flake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Is this function used anywhere else then with bars? Should bar also support dataframes, like

df = pd.DataFrame({0:[1,2,3]},index=[1,2,3])

This works with plt.scatter(df, [3,4,5]), but probably not with plt.bar(df, [3,4,5]), right?

I don't think

df = pd.DataFrame({'boo':[1,2,3]},index=[1,2,3])
plt.figure()
plt.bar(df, 1, width=.2)

ever worked (TypeError: float() argument must be a string or a number, not 'NoneType' on 3.0.0). The error with this PR if the data name is called 0 is a bit more mysterious, but that's a relatively perverse data frame (I hope).

Ok, just take df = pd.DataFrame([1,2,3]) then. I think it would be good to define whether single-column dataframes are supposed to work or not. They do for scatter/plot, so one might expect that, but if they don't, maybe a message that is a bit more helpful than "Your linewidth is wrong" would be useful.

This PR is trying to fix something I broke, not expand the duck typing for bar.

Use `safe_first_element` from cbook which does the `next(iter(x))` dance to get the first element of an object (as defined by what you get when you iterate over it).

This is great! Should have checked cbook....

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v3.1.x
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 e67c2fbfc257a1f3414eebfe873b78552ba9a7f3

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #15166: FIX: indexed pandas bar'

Push to a named branch :

git push YOURFORK v3.1.x:auto-backport-of-pr-15166-on-v3.1.x

Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #15166 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

FIX: indexed pandas bar

Backport PR #15166 on branch v3.1.x

backported in #15172 / 169a9f7

FIX: indexed pandas bar

10770e9

jklymak force-pushed the fix-indexed-pandas-bar branch from d472ac8 to 10770e9 Compare August 31, 2019 23:36

jklymak added this to the v3.1.2 milestone Aug 31, 2019

jklymak added third-party integration topic: units and array ducktypes Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Aug 31, 2019

MNT: simplify getting the first element

a023ecf

Use `safe_first_element` from cbook which does the `next(iter(x))` dance to get the first element of an object (as defined by what you get when you iterate over it).

jklymak commented Sep 1, 2019

View reviewed changes

tacaswell approved these changes Sep 1, 2019

View reviewed changes

dstansby approved these changes Sep 2, 2019

View reviewed changes

dstansby merged commit e67c2fb into matplotlib:master Sep 2, 2019

lumberbot-app Bot added the Still Needs Manual Backport label Sep 2, 2019

dstansby added a commit to dstansby/matplotlib that referenced this pull request Sep 2, 2019

Merge pull request matplotlib#15166 from jklymak/fix-indexed-pandas-bar

dcb48c3

FIX: indexed pandas bar

NelleV added a commit that referenced this pull request Sep 2, 2019

Merge pull request #15172 from dstansby/backport-15166

169a9f7

Backport PR #15166 on branch v3.1.x

tacaswell removed the Still Needs Manual Backport label Sep 2, 2019

ImportanceOfBeingErnest mentioned this pull request Sep 30, 2019

Bar width expands between subsequent bars #15351

Closed

jklymak mentioned this pull request Feb 1, 2020

Bar plot of pandas Series requires first index value to be 0 #16387

Closed

                           # wrap numpy arrays.
                           try:
-                              x0 = x0[0]
+                              x0 = cbook.safe_first_element(x0)

FIX: indexed pandas bar by jklymak · Pull Request #15166 · matplotlib/matplotlib · GitHub

Repository navigation

FIX: indexed pandas bar - #15166

FIX: indexed pandas bar#15166
dstansby merged 2 commits into
matplotlib:masterfrom
jklymak:fix-indexed-pandas-bar

jklymak commented Aug 31, 2019

Uh oh!

ImportanceOfBeingErnest commented Sep 1, 2019

Uh oh!

jklymak commented Sep 1, 2019 •
edited
Loading

Uh oh!

Uh oh!

ImportanceOfBeingErnest commented Sep 1, 2019

Uh oh!

jklymak commented Sep 1, 2019

Uh oh!

jklymak Sep 1, 2019 •
edited
Loading

Uh oh!

Uh oh!

lumberbot-app Bot commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FIX: indexed pandas bar by jklymak · Pull Request #15166 · matplotlib/matplotlib · GitHub

Repository navigation

FIX: indexed pandas bar - #15166

FIX: indexed pandas bar#15166dstansby merged 2 commits intomatplotlib:mastermatplotlib/matplotlib:masterfrom jklymak:fix-indexed-pandas-barjklymak/matplotlib:fix-indexed-pandas-barCopy head branch name to clipboard

Conversation

jklymak commented Aug 31, 2019

PR Summary

PR Checklist

Uh oh!

ImportanceOfBeingErnest commented Sep 1, 2019

Uh oh!

jklymak commented Sep 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ImportanceOfBeingErnest commented Sep 1, 2019

Uh oh!

jklymak commented Sep 1, 2019

Uh oh!

jklymak Sep 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lumberbot-app Bot commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FIX: indexed pandas bar#15166
dstansby merged 2 commits into
matplotlib:masterfrom
jklymak:fix-indexed-pandas-bar

jklymak commented Sep 1, 2019 •
edited
Loading

jklymak Sep 1, 2019 •
edited
Loading

tacaswell commented Sep 2, 2019 •
edited
Loading