Repository navigation
Fix typo/bug from 18cecf7 - #15296
Merged
jklymak merged 1 commit intoSep 18, 2019
Merged
jklymak merged 1 commit into
jklymak merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ImportanceOfBeingErnest
approved these changes
Sep 18, 2019
jklymak
approved these changes
Sep 18, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 18, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 18, 2019
Copy link
Copy Markdown
Member
|
No worries, I should have seen it when merging too. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
To quote Michael Droettboom quoting one of his early bosses "If you don't break the build, you are not writing enough code" ;). Mistakes happen 🤷♀️ thanks for finding it and fixing it quickly! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
See #15271 (review)
I'm sorry, this slipped in with a force push in some late stage.