Repository navigation
Use FixedFormatter only with FixedLocator - #15507
Merged
anntzer merged 1 commit intoDec 30, 2019
Merged
anntzer merged 1 commit into
anntzer merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Seems reasonable, but fails 15 tests! |
Sorry, something went wrong.
timhoffm
force-pushed
the
fixed-formatter
branch
from
63bf548 to
27df784
Compare
October 27, 2019 15:43
timhoffm
force-pushed
the
fixed-formatter
branch
2 times, most recently
from
4f9a9fe to
332cb4a
Compare
October 27, 2019 21:02
jklymak
reviewed
Oct 31, 2019
Comment thread
lib/matplotlib/axis.py
Outdated
timhoffm
force-pushed
the
fixed-formatter
branch
from
332cb4a to
88d178d
Compare
November 1, 2019 08:50
Copy link
Copy Markdown
Member
|
TypeError: _warn_external() got an unexpected keyword argument 'stacklevel' 😉 |
Sorry, something went wrong.
timhoffm
force-pushed
the
fixed-formatter
branch
from
88d178d to
c779568
Compare
November 1, 2019 14:12
jklymak
reviewed
Nov 1, 2019
Comment thread
lib/matplotlib/axis.py
Outdated
timhoffm
force-pushed
the
fixed-formatter
branch
2 times, most recently
from
578236a to
29b63c7
Compare
November 1, 2019 17:39
jklymak
approved these changes
Nov 1, 2019
anntzer
reviewed
Dec 2, 2019
Comment thread
lib/matplotlib/axes/_base.py
Outdated
anntzer
previously approved these changes
Dec 2, 2019
anntzer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
just one nit
Sorry, something went wrong.
timhoffm
force-pushed
the
fixed-formatter
branch
from
29b63c7 to
d538802
Compare
December 2, 2019 17:46
anntzer
reviewed
Dec 2, 2019
Comment thread
lib/matplotlib/axis.py
Outdated
anntzer
dismissed
their stale review
December 2, 2019 18:30
actually a real (minor) thing to fix on the warning too
timhoffm
force-pushed
the
fixed-formatter
branch
2 times, most recently
from
8481e72 to
a473ba1
Compare
December 3, 2019 05:17
timhoffm
force-pushed
the
fixed-formatter
branch
from
a473ba1 to
4b5284f
Compare
December 3, 2019 17:20
anntzer
approved these changes
Dec 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR prevents users from stumbling into #7122, #8779, #15501.
It does not technically fix them, FixedFormatter has a one-off bug with locators other than FixedLocator. But setting fixed labels at unknown positions is anyway not a good idea. So even if the one-off bug was fixed FixedFormatter should only used with FixedLocator.
One could set the formatter first and the locator afterwards, which would technically yield the correct result. However, I feel that setting the position first and the labels second is the natural way, and is actually done throughout the library.
No alternative: Since Formatters don't know about Locators FixedFormatter itself cannot check at runtime and we have to resort to this somewhat clumsy approach.
And I strongly want some feedback on this potential problem from running code, because nobody reads the docs 😄.