Repository navigation
Make sure that figures are closed when check_figures_equal finishes - #15589
Merged
dopplershift merged 1 commit intoNov 2, 2019
Merged
dopplershift merged 1 commit into
dopplershift merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
approved these changes
Nov 2, 2019
anntzer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This would be rather painful to test because one would need to disable the "figure-autoclose" autofixture to see any effects, so I think this can go in without tests.
Sorry, something went wrong.
dopplershift
approved these changes
Nov 2, 2019
This was referenced Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #15079. Closes figures after check_figures_equal has finished so that different tests don't overwrite each others' figures.
PR Checklist