FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Define \mathdefault as a noop in the usetex preamble. by anntzer · Pull Request #15695 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Define \mathdefault as a noop in the usetex preamble. - #15695

Merged
jklymak merged 2 commits into
matplotlib:masterfrom
anntzer:mathdefault
Dec 13, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Define \mathdefault as a noop in the usetex preamble.#15695
jklymak merged 2 commits into
matplotlib:masterfrom
anntzer:mathdefault

Conversation

anntzer commented Nov 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This avoids having to strip out \mathdefault (a non-existent latex
command) before generating usetex strings, as that's brittle on tickers
-- the global usetex flag may change after the ticker is instantiated.

Closes #10317.

(Note that we claim that the semantics of \mathdefault is "match the non-math font", but in usetex mode we previously just stripped it out anyways; making TeX actually use the non-math font in math would be... trickier.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm reviewed Nov 17, 2019
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should get documentation:

anntzer commented Nov 17, 2019

Copy link
Copy Markdown
Contributor Author

This is already documented in https://matplotlib.org/devdocs/tutorials/text/mathtext.html (look up \mathdefault there).

Added comments, and also refactored the preamble-getting in to avoid duplicating that between make_tex and make_tex_preview.

jklymak commented Dec 12, 2019

Copy link
Copy Markdown
Member

This looks good, but can this also get a test for the breaking case so it doesn't break again?

Define \mathdefault as a noop in the usetex preamble.
76d5b43 
This avoids having to strip out \mathdefault (a non-existent latex
command) before generating usetex strings, as that's brittle on tickers
-- the global usetex flag may change after the ticker is instantiated.
Dedupe texmanager preamble construction.
7ccccc0

anntzer commented Dec 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

sure... done

jklymak added this to the v3.3.0 milestone Dec 13, 2019
jklymak merged commit 508f21f into matplotlib:master Dec 13, 2019

jklymak commented Dec 13, 2019

Copy link
Copy Markdown
Member

Feel free to re-milestone and back port if we think thats important....

anntzer deleted the mathdefault branch December 13, 2019 20:51

pyZerrenner commented Dec 13, 2019

Copy link
Copy Markdown

Thanks for fixing this! This solution is much simpler than my idea :)

anntzer commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

You are welcome :)

tacaswell modified the milestones: v3.3.0, v3.2.2 Apr 28, 2020

tacaswell commented Apr 28, 2020

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.2.x

lumberbot-app Bot commented Apr 28, 2020

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 508f21fb42d172201e5048b701fa13e16868bac7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15695: Define \\mathdefault as a noop in the usetex preamble.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-15695-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #15695 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Apr 28, 2020
Merge pull request matplotlib#15695 from anntzer/mathdefault
74becc4 
Define \mathdefault as a noop in the usetex preamble.

Conflicts:
   lib/matplotlib/ticker.py
      change of a near-by conditional from np.abs -> abs caused
      conflict
oscargus mentioned this pull request Oct 2, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: text/usetex

Projects

None yet

Milestone

v3.2.2

Development

Successfully merging this pull request may close these issues.

Setting plt.rc('text', usetex=True) after ticker.ScalarFormatter(useMathText=True) causes Error

6 participants

Back | FazBrowse Home | New Git URL