FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make animation blit cache robust against 3d viewpoint changes. by anntzer · Pull Request #16070 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Make animation blit cache robust against 3d viewpoint changes. - #16070

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:anim3dblit
Jan 4, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Make animation blit cache robust against 3d viewpoint changes.#16070
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:anim3dblit

Conversation

anntzer commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

Instead of connecting to the xlim_changed/ylim_changed events to clear
the blit cache, use Axes._get_view(), which also works for 3d axes.

Closes #16069. No test because good luck with that, but one can repro with the example at that issue.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm reviewed Jan 2, 2020
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This changes the view checking from notification to polling. We have to execute _get_view() every time we want to use the background. Have you evaluated the performance impact?

Can we introduce a generic view_changed callback instead.

anntzer commented Jan 2, 2020

Copy link
Copy Markdown
Contributor Author

_get_view returns the axes limits (plus the view angles in 3D), which is something that needs to be accessed anyways for drawing the artist. So yes it's a couple more attribute accesses but I doubt it matters (but I have not checked this).

In theory custom projections need to implement _get_view anyways to interact properly with the home/previous/next buttons, so it seems annoying to request that they additionally need to implement view_changed (_get_view and view_changed going out of sync would be yet another possible source of bugs, whereas if there's only one source of truth, it can't go out of sync with itself).

tacaswell added this to the v3.3.0 milestone Jan 4, 2020
tacaswell reviewed Jan 4, 2020
View reviewed changes
Comment thread lib/matplotlib/animation.py Outdated
pass
else:
if ax._get_view() == view:
ax.figure.canvas.restore_region(bg)

tacaswell Jan 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Might as well evict invalid backgrounds here as well?

anntzer Jan 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done, good point.

tacaswell commented Jan 4, 2020

Copy link
Copy Markdown
Member

This seems to be simpler over all. While this is in the hot-loop of the animation loop so we should be concerned, but on my few year laptop, ax._get_view() takes ~9us. My (un-benchmarked) hunch as that we are getting back more than that with the other cleanups in this PR.

tacaswell approved these changes Jan 4, 2020
View reviewed changes

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

modulo pre-emptive cache eviction.

Make animation blit cache robust against 3d viewpoint changes.
0539da4 
Instead of connecting to the xlim_changed/ylim_changed events to clear
the blit cache, use Axes._get_view(), which also works for 3d axes.
timhoffm merged commit ca1330c into matplotlib:master Jan 4, 2020
anntzer deleted the anim3dblit branch January 4, 2020 12:53
anntzer mentioned this pull request Jan 23, 2020
Closed
anntzer mentioned this pull request Mar 30, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: animation

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

matplotlib glitch when rotating interactively a 3d animation

3 participants

Back | FazBrowse Home | New Git URL