Repository navigation
Expire the _rename_parameters API changes. - #16491
Merged
story645 merged 1 commit intoFeb 25, 2020
Merged
story645 merged 1 commit into
story645 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
rename_parameters
branch
from
838fc14 to
4d6bad7
Compare
February 13, 2020 10:18
timhoffm
approved these changes
Feb 15, 2020
jklymak
approved these changes
Feb 16, 2020
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
CI failure seems real though...
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sphinx has three warnings: /usr/local/lib/python3.8/importlib/__init__.py:127: MatplotlibDeprecationWarning: The mpl_toolkits.axes_grid1.colorbar module was deprecated in Matplotlib 3.2 and will be removed two minor releases later. Use matplotlib.colorbar instead. reading sources... [ 12%] api/_as_gen/matplotlib.axes.Axes.secondary_xaxis <string>:6: RuntimeWarning: divide by zero encountered in true_divide /home/circleci/project/doc/api/next_api_changes/removals.rst:150: WARNING: py:obj reference target not found: bezier of which i think only the last one really counts for the failure (build finished with problems, 1 warning.) |
Sorry, something went wrong.
anntzer
force-pushed
the
rename_parameters
branch
from
4d6bad7 to
9bf0b9d
Compare
February 16, 2020 10:06
Copy link
Copy Markdown
Contributor
Author
|
Added an api entry for matplotlib.bezier to resolve the missing ref. |
Sorry, something went wrong.
I put the changelog not under "removals", though they could possibly go under "behavior changes" instead?
anntzer
force-pushed
the
rename_parameters
branch
from
9bf0b9d to
6e0b093
Compare
February 16, 2020 13:16
story645
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put the changelog not under "removals", though they could possibly go
under "behavior changes" instead?
PR Summary
PR Checklist