Repository navigation
Also deprecate ignorecase ValidateInStrings. - #16531
Merged
timhoffm merged 1 commit intoFeb 17, 2020
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Prepending a flag is a quite hacky. Instead of ['toolbar2', [re.I, 'none', 'toolbar2', 'toolmanager']], I'd go for something like ['toolbar2', ['none', 'toolbar2', 'toolmanager'], re.I], # or ['toolbar2', ignore_case(['none', 'toolbar2', 'toolmanager'])], with a suitable ignore_case function. |
Sorry, something went wrong.
... by using re.I ("ignorecase") as marker for those.
Copy link
Copy Markdown
Contributor
Author
|
Ah, ignore_case is much nicer indeed, changed accordingly. |
Sorry, something went wrong.
timhoffm
approved these changes
Feb 16, 2020
tacaswell
approved these changes
Feb 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by using re.I ("ignorecase") as marker for those.
Unlike #16483 I'm not 100% convinced this is an improvement, just >50% :)
PR Summary
PR Checklist