Repository navigation
Deprecate autofmt_xdate(which=None) to mean which="major". - #16636
Merged
QuLogic merged 1 commit intoMar 11, 2020
Merged
QuLogic merged 1 commit into
QuLogic merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timhoffm
approved these changes
Mar 3, 2020
QuLogic
approved these changes
Mar 10, 2020
This makes the docstring and signature simpler, and explicitly passing which=None to mean which="major" just seems wicked...
Copy link
Copy Markdown
Contributor
Author
|
rebased |
Sorry, something went wrong.
anntzer
force-pushed
the
autofmtxdate_major
branch
from
d5795c9 to
e53eedb
Compare
March 10, 2020 23:59
Copy link
Copy Markdown
Member
|
Test failure is due to #16693, and I can't restart. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the docstring and signature simpler, and explicitly passing
which=None to mean which="major" just seems wicked...
PR Summary
PR Checklist