Repository navigation
Avoid floating point rounding causing bezier.get_parallels to fail - #16682
Merged
anntzer merged 1 commit intoMar 5, 2020
Merged
anntzer merged 1 commit into
anntzer merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is the diff provided by @anntzer [here](matplotlib#12820 (comment)) Closes matplotlib#12820
Copy link
Copy Markdown
Member
|
Test failure looks like it is conda failing. |
Sorry, something went wrong.
tacaswell
approved these changes
Mar 5, 2020
tacaswell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
👍
We already have tests that hit this code path (but not the exact values that failed). I don't think it is worth adding a fine-tuned test.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks again for your work on tracking this down @ksunden ! There are a lot of unsung heroes in open source, but people who track down error conditions that depend on 13 significant digits have a special place in my ❤️ . |
Sorry, something went wrong.
anntzer
approved these changes
Mar 5, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 5, 2020
…ezier.get_parallels to fail
tacaswell
added a commit
that referenced
this pull request
Mar 6, 2020
…682-on-v3.2.x Backport PR #16682 on branch v3.2.x (Avoid floating point rounding causing bezier.get_parallels to fail)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Avoids failing due to a very particular floating point cutoff
mismatch when determining if two lines are parallel via two different
methods.
This is the diff provided by @anntzer here
Closes #12820
PR Checklist
I am unclear what, if any, tests are expected for this diff, as
discussed in #12820. Causing this to happen on an actual figure requires
a rather unlucky set of very specific layout and annotation placement
that is difficult to replicate. A simple test of get_parallels is
possible, but probably not particularly helpful.
My understanding is that since this is only changing floating point
cutoff behaviour, this is not considered an API change, therefore I did
not write a release note. If I am mistaken, please let me know.