FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bug fix 16583 - resetup.py param xtick.alignment updated to properly validate values by MuhammadFarooq1234 · Pull Request #16712 · matplotlib/matplotlib · GitHub

Repository navigation

Bug fix 16583 - resetup.py param xtick.alignment updated to properly validate values - #16712

Closed
MuhammadFarooq1234 wants to merge 3 commits into
matplotlib:masterfrom
CSCD01:BugFix-16583
Closed

MuhammadFarooq1234 wants to merge 3 commits into
matplotlib:masterfrom
CSCD01:BugFix-16583

Conversation

MuhammadFarooq1234 commented Mar 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This PR is for 16583. When setting xtick.alignment (rcsetup.py) parameter globally in matplotlib, the xtick.alignment parameter was not validating against the correct possible values. Value Error thrown when any value, valid or not, was set. Now users, can properly set xtick alignment globally using valid values 'center', 'left', or 'right'.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

story645 commented Mar 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Did you intend to close this pull request?

QuLogic commented Apr 23, 2020

Copy link
Copy Markdown
Member

Replaced by #16727.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL