Repository navigation
Unbreak CI by xfailing wxAgg test on macOS - #16870
Merged
tacaswell merged 1 commit intoMar 23, 2020
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tacaswell
approved these changes
Mar 23, 2020
Copy link
Copy Markdown
Member
|
The travis failure is a known file system race (test_loglog_nonpos[png-True]) that I think we have PR in flight to prevent. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
$ git checkout v3.2.x $ git pull
$ git cherry-pick -m1 7352a13612a7bf6c3463edeec3e14c0490341a1b
$ git commit -am 'Backport PR #16870: Unbreak CI by xfailing wxAgg test on macOS'
git push YOURFORK v3.2.x:auto-backport-of-pr-16870-on-v3.2.x
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Mar 23, 2020
Merge pull request matplotlib#16870 from timhoffm/xfail CI: Unbreak CI by xfailing wxAgg test on macOS Conflicts: lib/matplotlib/tests/test_backends_interactive.py - Other improvements to messages when skipping tests from bc155f0 near by. Did not implicitly backport other changes.
tacaswell
added a commit
that referenced
this pull request
Mar 23, 2020
…-v3.2.x Backport PR #16870: Unbreak CI by xfailing wxAgg test on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a stopgap for #16849, which does not yet have a solution. We just xfail the test for now so that other PRs pass CI.