Repository navigation
Path center of mass - #16889
Draft
brunobeltran wants to merge 4 commits into
Draft
Path center of mass#16889brunobeltran wants to merge 4 commits into
brunobeltran wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Mar 23, 2020
Closed
Open
brunobeltran
force-pushed
the
path_center_of_mass
branch
from
a933565 to
08faaf5
Compare
March 23, 2020 23:27
brunobeltran
force-pushed
the
path_center_of_mass
branch
7 times, most recently
from
82b1359 to
348e7e1
Compare
March 31, 2020 02:03
brunobeltran
force-pushed
the
path_center_of_mass
branch
from
348e7e1 to
cb37c8f
Compare
April 9, 2020 21:28
brunobeltran
force-pushed
the
path_center_of_mass
branch
from
cb37c8f to
23ae477
Compare
April 20, 2020 03:05
jklymak
marked this pull request as draft
July 23, 2020 03:18
Copy link
Copy Markdown
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We should allow users to center markers by center of mass. This is the code to compute the center of mass of an arbitrary path (treats paths of different intrinsic dimension correctly).
Roadmap:
#16812 (*) <- #16832 (*) <- #16859 (*) <- #16888 (*) <- (This PR) (*) <- #16891 (MarkerStyle improvements!)
"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.
PR Checklist