Repository navigation
you can't call CGDataProviderCreateWithData on a stack pointer - #17263
Merged
dopplershift merged 1 commit intoMay 2, 2020
Merged
dopplershift merged 1 commit into
dopplershift merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…s not allowed Without this fix, matplotlib will crash on an upcoming release of Mac OS, becuase the CGDataProvider it creates will be accessed on a different thread after it's stack allocation's lifetime has ended.
Copy link
Copy Markdown
Member
|
Thanks! @lawrence-danna-apple would you be willing to comment on #17084 ? |
Sorry, something went wrong.
QuLogic
approved these changes
Apr 29, 2020
QuLogic
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Someone on macOS should test this, but the (Obj)C code makes sense.
Sorry, something went wrong.
Merged
1 of 6 tasks
tacaswell
approved these changes
Apr 30, 2020
tacaswell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I agree, code changes look correct, but someone with an OSX machine should test this out and then merge.
Sorry, something went wrong.
dopplershift
approved these changes
May 2, 2020
dopplershift
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Tested and seems to work fine for me here.
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 2, 2020
…Data on a stack pointer
QuLogic
added a commit
that referenced
this pull request
May 2, 2020
…263-on-v3.2.x Backport PR #17263 on branch v3.2.x (you can't call CGDataProviderCreateWithData on a stack pointer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's illegal to call CGDataProviderCreateWithData on a stack pointer.
Without this fix, matplotlib will crash on an upcoming release of Mac OS, becuase
the CGDataProvider it creates will be accessed on a different thread after
its stack allocation's lifetime has ended.