FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FIX: add set_box_aspect, improve tight bounding box for Axes3D + fix bbox_inches support with fixed box_aspect by tacaswell · Pull Request #17515 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

FIX: add set_box_aspect, improve tight bounding box for Axes3D + fix bbox_inches support with fixed box_aspect #17515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 12 commits into from
Jun 6, 2020
Conversation 50 Commits 12 Checks 0 Files changed
Merged

FIX: add set_box_aspect, improve tight bounding box for Axes3D + fix bbox_inches support with fixed box_aspect #17515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc43279
MNT: make sure Axes3D methods handle sharez correctly
tacaswell May 27, 2020
b9f9d2e
ENH: implement get_tightbbox on Axis3D
tacaswell May 27, 2020
8c2529a
ENH: Add support for Axes3D.set_pb_aspect
eric-wieser Jul 18, 2017
6915f69
ENH: use box_aspect to support setting pb_aspect
tacaswell May 27, 2020
c0ab395
FIX: support bbox_inches='tight' for box_aspect Axes
tacaswell May 30, 2020
b021ff4
MNT: suggestions from review
tacaswell May 30, 2020
8e6e83c
DOC: correct typos and markup
tacaswell Jun 3, 2020
7cde8de
DOC: clearify and simplify docstring
tacaswell Jun 4, 2020
4c0b944
DOC: clarify docs on Axes3D.set_aspect and Axes3D.set_box_aspect
tacaswell Jun 5, 2020
eea3d1a
MNT: do minimal input validation in Axes3D.set_box_aspect
tacaswell Jun 5, 2020
910bfe5
FIX: correct text of error message
tacaswell Jun 5, 2020
8ee34a9
MNT: be more careful about handling pre-monkey patched Axes
tacaswell Jun 5, 2020
File filter

Filter by extension

Filter by extension .png  (1) .py  (6) .rst  (1) .svg  (1) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 9 additions & 2 deletions doc/users/next_whats_new/2019-03-25-mplot3d-projection.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
Plots made with :class:`~mpl_toolkits.mplot3d.axes3d.Axes3D` were previously
stretched to fit a square bounding box. As this stretching was done after
the projection from 3D to 2D, it resulted in distorted images if non-square
bounding boxes were used.
bounding boxes were used. As of 3.3, this no longer occurs.

As of this release, this no longer occurs.
Currently, modes of setting the aspect (via
`~mpl_toolkits.mplot3d.axes3d.Axes3D.set_aspect`) in data space are
not supported for Axes3D but may be in the future. If you want to
simulate having equal aspect in data space, set the ratio of your data
limits to match the value of `~.get_box_aspect`. To control these
ratios use the `~mpl_toolkits.mplot3d.axes3d.Axes3D.set_box_aspect`
method which accepts the ratios as a 3-tuple of X:Y:Z. The default
aspect ratio is 4:4:3.
4 changes: 0 additions & 4 deletions lib/matplotlib/axes/_base.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1339,10 +1339,6 @@ def set_aspect(self, aspect, adjustable=None, anchor=None, share=False):
if cbook._str_equal(aspect, 'equal'):
aspect = 1
if not cbook._str_equal(aspect, 'auto'):
if self.name == '3d':
raise NotImplementedError(
'It is not currently possible to manually set the aspect '
'on 3D axes')
aspect = float(aspect) # raise ValueError if necessary

if share:
Expand Down
Loading
Back | FazBrowse Home | New Git URL